Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(setting): modify the setting description #987

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

mantissahz
Copy link
Contributor

Which issue(s) this PR fixes:

Issue # longhorn/longhorn#9391

What this PR does / why we need it:

Modify the setting Default Longhorn Static Storage Class Name description.

Special notes for your reviewer:

Additional documentation or context

@mantissahz mantissahz self-assigned this Sep 9, 2024
@mantissahz mantissahz requested a review from a team as a code owner September 9, 2024 04:11
Copy link

netlify bot commented Sep 9, 2024

Deploy Preview for longhornio ready!

Name Link
🔨 Latest commit c07a01d
🔍 Latest deploy log https://app.netlify.com/sites/longhornio/deploys/66e12a4b94935a000828ef8f
😎 Deploy Preview https://deploy-preview-987--longhornio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@jhkrug jhkrug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of typo corrections.

content/docs/1.7.2/references/settings.md Outdated Show resolved Hide resolved
@derekbit
Copy link
Member

derekbit commented Sep 11, 2024

@mantissahz Need to update v1.8.0-dev and v1.6.3-dev as well. Thank you.

Modify the setting `Default Longhorn Static Storage Class Name`
description.

ref longhorn/longhorn 9391

Signed-off-by: James Lu <james.lu@suse.com>
@mantissahz
Copy link
Contributor Author

@mantissahz Need to update v1.8.0-dev and v1.6.3-dev as well. Thank you.

Added. Thanks

Copy link
Contributor

@jhkrug jhkrug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@derekbit derekbit merged commit d864278 into longhorn:master Oct 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants